add monitor design pattern . #1640
Conversation
There was a problem hiding this comment.
Thank you so much for taking out the time to contribute to this repository.
Add to parent pom module for building so that the CI can check.
Please be sure to check out the Wiki section as it can improve the quality of the Pull Request you have created.
|
@Dev-AliGhasemi probably this issue #466 |
|
i added class diagram ! |
|
@Dev-AliGhasemi I am a tad busy this week, will check this out by the weekend. Thanks |
|
Thanks @iluwatar for the insight! @Dev-AliGhasemi Please amend the changes requested by @iluwatar here in the review comment. |
|
i deleted all mvnw files but still not work ! |
There was a problem hiding this comment.
@Dev-AliGhasemi fixed the issue with mvnw
Now you can continue working with it
|
Kudos, SonarCloud Quality Gate passed!
|
|
why there is not monitor pattern in this list here ? |
There was a problem hiding this comment.
why there is not monitor pattern in this list here ?
I really did not understand the context here.
It would be great if you could explain a bit further so that we can clarify on our part.
Please mention us when this Pull Request is ready to review.
On your part you need to work on providing test cases and increase coverage of code with more than 80%
|
is my design pattern ok ? and is it ready to publish ? |
Please take a look at my previous comment. |
i have to write test cases to complete this pattern and publish it ? |
That is absolutely correct. Test Cases with 80% and above of coverage. |
|
@iluwatar |
|
Kudos, SonarCloud Quality Gate passed!
|
|
It was a long road, but we got there eventually. Thanks for putting the new pattern together! |
|
I've put up a pull request to add @Dev-AliGhasemi! 🎉 |
|
Thank's @iluwatar |
There was a problem hiding this comment.
@iluwatar This pattern was never added to the parent POM the reason why SONAR was never generated.
I believe we should have checked for SONAR issues before merging this code.
Moreover the project is not getting built in the first place. I believe we should revert these two commits and take another round of look before merging this again to the master.
|
@ohbus thanks for noticing it. I think we can address the thing with another issue and not have to revert the merge. |
|
Added bug ticket #1871. @Dev-AliGhasemi would you like to try to fix it? If yes, please comment on the issue and we'll assign it to you. |
* add monitor design pattern . * add extra line and change compiler version to 11 in pom.xml. * encapsulate getBalance method . * update puml file . * export uml as png . * duplicate codes eliminated . * update tag * change the format of pom.xml * using logger to print * change AtomicRefrence to type inference var * explanations added ! * Update monitor/README.md Co-authored-by: Ilkka Seppälä <[email protected]> * Update monitor/README.md Co-authored-by: Ilkka Seppälä <[email protected]> * Update monitor/src/main/java/com/iluwatar/monitor/Main.java Co-authored-by: Ilkka Seppälä <[email protected]> * Update monitor/src/main/java/com/iluwatar/monitor/Main.java Co-authored-by: Ilkka Seppälä <[email protected]> * Update monitor/src/main/java/com/iluwatar/monitor/Main.java Co-authored-by: Ilkka Seppälä <[email protected]> * Update monitor/src/main/java/com/iluwatar/monitor/Main.java Co-authored-by: Ilkka Seppälä <[email protected]> * e.printStackTrace have changed to logger to prints standard output (STD OUT) . * add programmatic example . * Delete mvnw * mvnw.cmd deleted . * added mvnw from master * AddUnitTest * Add language to readme.md Co-authored-by: Subhrodip Mohanta <[email protected]> Co-authored-by: Ilkka Seppälä <[email protected]> Co-authored-by: Subhrodip Mohanta <[email protected]> Co-authored-by: Subhrodip Mohanta <[email protected]>
Add Monitor design pattern
Monitor pattern is used to create thread-safe object . In the concurrent application to prevent conflict between threads .
Pull request description
add new design pattern as Monitor !