Skip to content

Monitor Object pattern #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iluwatar opened this issue Jul 19, 2016 · 21 comments · Fixed by #1640
Closed

Monitor Object pattern #466

iluwatar opened this issue Jul 19, 2016 · 21 comments · Fixed by #1640
Labels
epic: pattern type: feature
Milestone
1.25.0

Comments

@iluwatar
Copy link
Owner

https://en.wikipedia.org/wiki/Monitor_(synchronization)
http://www.javaworld.com/article/2077769/core-java/better-monitors-for-java.html
@Amarnath510
Copy link
Contributor

@iluwatar I want to work on this.

@iluwatar
Copy link
Owner Author

@Amarnath510 yes, please go ahead 👍

@Amarnath510
Copy link
Contributor

@iluwatar
I am working on this one. I'll be submitting the design in a week.

@iluwatar
Copy link
Owner Author

Great @Amarnath510, I'll update the issue labels.

@Amarnath510
Copy link
Contributor

@iluwatar Could you also check the blog post and review it?
I have made all the suggested changes.

@iluwatar iluwatar mentioned this issue Jan 14, 2017
Closed
@Amarnath510
Copy link
Contributor

@iluwatar
I am occupied these days and I'll be busy for the next couple of weeks or so.
Could you please mark this pattern as "help wanted" if you need to complete this soon.
In case you are not in a hurry I can take this up after a month.

@iluwatar
Copy link
Owner Author

@Amarnath510 I'll mark the issue free for taking. Feel free to reclaim it later.

@PJozeph
Copy link

PJozeph commented Jan 26, 2017 •
edited
Loading

@iluwatar apologize to write here without adding any suggestion, i am code newbie at the stage of figuring out how to contribute.
the task here is the demonstrate how Hoare-style monitors is working ?

@iluwatar
Copy link
Owner Author

@PJozeph that is correct. To get started please read through https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute.

@nikhilbarar
Copy link
Contributor

I'd like to implement this. Please let me know if its still open

@iluwatar
Copy link
Owner Author

iluwatar commented Jun 7, 2018

Yes, go ahead @nikhilbarar

nikhilbarar added a commit to nikhilbarar/java-design-patterns that referenced this issue Jun 12, 2018
@nikhilbarar
Monitor Object pattern iluwatar#466
4456a44
nikhilbarar added a commit to nikhilbarar/java-design-patterns that referenced this issue Jun 12, 2018
@nikhilbarar
iluwatar#466: Fix Checkstyle Issues
d54e290
@nikhilbarar
Copy link
Contributor

nikhilbarar commented Jun 12, 2018 •
edited
Loading

PR #768 Please let me know if any changes are required. Thanks

nikhilbarar added a commit to nikhilbarar/java-design-patterns that referenced this issue Jun 13, 2018
@nikhilbarar
iluwatar#466, iluwatar#509: Added diagrams and Readme files
71f61cd
nikhilbarar added a commit to nikhilbarar/java-design-patterns that referenced this issue Jul 8, 2018
@nikhilbarar
iluwatar#466: Monitor Object pattern
19df407
nikhilbarar added a commit to nikhilbarar/java-design-patterns that referenced this issue Jul 8, 2018
@nikhilbarar
iluwatar#466: Added diagrams and Readme files
02d9bed
nikhilbarar added a commit to nikhilbarar/java-design-patterns that referenced this issue Aug 1, 2018
@nikhilbarar
iluwatar#466: Checkstyle Fixes
db7a279
nikhilbarar added a commit to nikhilbarar/java-design-patterns that referenced this issue Aug 2, 2018
@nikhilbarar
iluwatar#466: Checkstyle Fixes
5b9d128
@iluwatar
Copy link
Owner Author

This issue is free for taking again

@Meccota
Copy link

Meccota commented Feb 29, 2020

Is this issue still open? I saw there are commits, if it needs implementation I would like to take it

@iluwatar
Copy link
Owner Author

@Meccota yes please go ahead

@iluwatar
Copy link
Owner Author

iluwatar commented Jul 6, 2020

@Meccota are you working on this?

@ohbus
Copy link
Contributor

ohbus commented Jan 2, 2021

This issue is free for taking again

@iluwatar iluwatar mentioned this issue Jan 30, 2021
Merged
@ohbus ohbus linked a pull request Apr 22, 2021 that will close this issue
add monitor design pattern . #1640
Merged
@castleKing1997
Copy link
Contributor

why this merging is blocked?

@iluwatar
Copy link
Owner Author

iluwatar commented Oct 8, 2021

It's close but not yet there

@castleKing1997
Copy link
Contributor

@iluwatar
I have reviewed the code in PR #768.
It implements the Hoare-style monitor very well.
I can help to reconstruct this code,
give a more detailed README
and make a new pull request.

@iluwatar
Copy link
Owner Author

@castleKing1997 I appreciate it, but let's wait a bit if @Dev-AliGhasemi resolves this with #1640

@iluwatar iluwatar added this to the 1.25.0 milestone Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic: pattern type: feature
Projects
None yet
Milestone
1.25.0
Development

Successfully merging a pull request may close this issue.

add monitor design pattern . Dev-AliGhasemi/java-design-patterns
7 participants
@iluwatar @Amarnath510 @ohbus @PJozeph @castleKing1997 @nikhilbarar @Meccota