Refactor Prototype pattern #1838
Conversation
|
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
@ThexXTURBOXx Thank you so much for your help and your interest to contribute to our repository.
However, we would want you to fix the Sonar issues that have been reported already before we take a look into your implementation.
Also make sure to add enough test cases to increase the code coverage to a minimum of 80%, though we always appreciate a full coverage of the same.
Looking forward to your contribution.
Cheers.
|
The pull request has remained inactive and is about to be closed. Please comment if you're still working on it. |
|
Ok @yonatankarp |
There was a problem hiding this comment.
There's open PR for this issue here: #1970 We can close this one...
|
Ok @yonatankarp, I'll close this one |
This PR refactors parts of the Prototype pattern by making it
Cloneableand thus inheriting theclone()method to its subclasses.