Skip to content

#450 Blog: Queue-Based Load Leveling Pattern #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Jan 13, 2017
Merged

#450 Blog: Queue-Based Load Leveling Pattern #526

merged 18 commits into from
Jan 13, 2017

Conversation

Amarnath510
Copy link
Contributor

I have added blog for Queue-Based Load Leveling Pattern. Please review the same.
There is one problem with images. I have added images to assets directory but still the images are not getting resolved. Please let me know how to resolve this issue.

@Amarnath510 Amarnath510 changed the title Blog: Queue-Based Load Leveling Pattern #450 Blog: Queue-Based Load Leveling Pattern Dec 8, 2016
@iluwatar
Copy link
Owner

The images show just fine on my local Jekyll. Did you check the instructions here https://github.com/iluwatar/java-design-patterns/wiki/07.-Working-with-the-web-site?

@iluwatar
Copy link
Owner

  • In the first image Queue-load-level-pattern.png I would rename tasks -> requests and message queue -> task queue.
  • In the second image Queue-load-level-scenario.png I'm not sure what is meant by "Web role instances". Could we talk about service requester role or something similar? Also as above, I would rename message queue -> task queue. Would it make sense to add multiple worker role instances in the picture to make it clear that there can be more than one?
  • The implementation section is somewhat torso at the moment. I would add and explain some of the core classes of the example here.
  • The author name is not displayed. Hopefully @markusmo3 can explain what is needed for the author name to show up correctly after the blog post. Do we have instruction for that?

@iluwatar iluwatar self-assigned this Dec 11, 2016
@Amarnath510
Copy link
Contributor Author

@iluwatar Thanks for the review.
I'm commenting on each of the points,

  • Actually the images are picked up straight from the post, so the names are the same. Do I need to create custom images?
  • Same as above point.
  • I will explain each class in detail.
  • Not sure about this.

@iluwatar
Copy link
Owner

@Amarnath510 we cannot take images from another web site and use them on ours because of copyright issues. I recommend that you create the images for the blog yourself.

@Amarnath510
Delete Queue-load-level-pattern.png
22fb067
@Amarnath510
Delete Queue-load-level-scenario.png
0890d08
@Amarnath510
Added new images for Queue Load Leveling.
af9d568 
Added new images for queue based load leveling pattern.
@Amarnath510
Updated blog with images and explained classes
6768781 
I have added new images and removed the old ones due to copyright issue.
Also explained each of the core classes in detail.
@Amarnath510
Copy link
Contributor Author

@iluwatar I have updated the images and added description for the core classes.
Please review the same.

@markusmo3
Copy link
Contributor

markusmo3 commented Dec 19, 2016 •
edited
Loading

To add an author, first add your shortname (e.g. mo3, ilu, ...) and your details in the people.yml.
Then you can reference this shortname in your blogpost under the 'author' variable

@iluwatar
Copy link
Owner

@Amarnath510 looks good already. Great pictures! Here are some additional comments:

  • The description of the classes is great, but can you also show the relevant code how it is implemented. For an example, see the how it is shown in the Hexagonal blog.
  • As @markusmo3 instructed above please add the author information to the blog post

Amarnath510 and others added 5 commits January 4, 2017 20:38
@Amarnath510
Updated Code for all the important classes
9ae66c9 
Added code for all the core classes.
@Amarnath510
Added new author name
1061d7b 
Added author name and github username.
@Amarnath510
Updated author name.
d24ae39 
Added author name with same name from people.yml file.
✨ 🆙 Automagic Update via Travis-CI
d6c96b3
Updated code and added new image.
e1fc6de
markusmo3
markusmo3 reviewed Jan 4, 2017
View reviewed changes
_config.yml
baseurl: "/java-design-patterns" # the subpath of your site, e.g. /blog/
url: "https://iluwatar.github.io" # the base hostname & protocol for your site
baseurl: "" # the subpath of your site, e.g. /blog/
url: "http://localhost:4000" # the base hostname & protocol for your site
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this change? with jekyll serve in the java-design-patterns directory it should display the site correctly including all links, because they are relative. Jekyll serves the site under http://127.0.0.1:4000/java-design-patterns/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusmo3
My mistakes I have not reverted my local changes in the config file.
Reagarding the change, it was mentioned at jekyll kick start point 6. So I have changed it locally.

I will revert the changes and commit again.

@Amarnath510
Copy link
Contributor Author

Amarnath510 commented Jan 5, 2017 •
edited
Loading

@markusmo3 / @iluwatar
I have completed the blog writing. Can you please look into it?
I don't know why build is failing but locally the blog looks great with no issue.

@Amarnath510 Amarnath510 mentioned this pull request Jan 11, 2017
Closed
@iluwatar iluwatar self-requested a review January 12, 2017 19:40
iluwatar
iluwatar approved these changes Jan 12, 2017
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blog post looks good and ready to publish to me. @markusmo3 if you approve too I will merge it. @Amarnath510 you still have a chance to update the blog post date and look for typos.

markusmo3
markusmo3 approved these changes Jan 12, 2017
View reviewed changes
Copy link
Contributor

@markusmo3 markusmo3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Amarnath510
Copy link
Contributor Author

@iluwatar Okay I will check for typos once again.
But where to change the data? I don't see any blog post date in the blog?
IMHO it should be the date we are publishing it right?

@iluwatar
Copy link
Owner

You can set the date by changing the filename of the post e.g. _posts/queue-load-leveling/2016-12-9-queue-load-leveling.md. We can use the current date or the date you want the post to go live. Let me know when you're ready with the final changes and I'll merge it.

@Amarnath510
Copy link
Contributor Author

@iluwatar Thanks for the quick response. I have changed the blog post name and there are no typos.
Completed all the work .. I hope we can see the blog going live soon .. 👍 👍 👍

@iluwatar iluwatar merged commit 36123ff into iluwatar:gh-pages Jan 13, 2017
@iluwatar iluwatar added this to the 1.15.0 milestone Jan 13, 2017
@iluwatar iluwatar mentioned this pull request Jan 13, 2017
Closed
@iluwatar
Copy link
Owner

Well done @Amarnath510, it is now live at http://java-design-patterns.com/blog/. Looking forward to your further high quality contributions! 👍

@Amarnath510
Copy link
Contributor Author

👍 👍 👍
@iluwatar Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

@markusmo3 markusmo3 markusmo3 approved these changes

Assignees

@iluwatar iluwatar

Labels
status: under review
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Amarnath510 @iluwatar @markusmo3