Modifications for intermittent test failure in Throttling pattern. #646
Conversation
| @@ -36,14 +36,15 @@ | |||
| @Test | |||
| public void dummyCustomerApiTest() { | |||
| Tenant tenant = new Tenant("testTenant", 2); | |||
| Throttler timer = new ThrottleTimerImpl(10); | |||
| Throttler timer = new ThrottleTimerImpl(100); | |||
There was a problem hiding this comment.
Any reason to change value from 10 to 100?
There was a problem hiding this comment.
Yes, sometimes the counter was being reset within the 10 ms period. To avoid that, the value is increased.
| } | ||
|
|
||
| /** | ||
| * | ||
| * @param tenantName name of the tenant. | ||
| * @return the count of the tenant. | ||
| */ | ||
| public static int getCount(String tenantName) { | ||
| return tenantCallsCount.get(tenantName); | ||
| public static Long getCount(String tenantName) { |
There was a problem hiding this comment.
Suggestion: Keep it long instead of wrapper counterpart
| private static Map<String, Integer> tenantCallsCount = new ConcurrentHashMap<>(); | ||
|
|
||
| private static final Logger LOGGER = LoggerFactory.getLogger(CallsCount.class); | ||
| private static Map<String, AtomicLong> tenantCallsCount = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
Question: Why change from int to long? Why not AtomicInteger? Is it because the call count can breach MAXINT limit?
| B2BService service = new B2BService(timer); | ||
|
|
||
|
|
||
| long counter = 0; |
There was a problem hiding this comment.
Can you explain briefly why are these changes needed?
There was a problem hiding this comment.
To be honest, I am unable to figure out this. The code works perfectly this way but if the counter is calculated outside the for loop(like done previously), then sometimes it is not reflecting the proper changes.
There was a problem hiding this comment.
I am sorry. I think I tested this method before incrementing the count limit from 10 to 100(which was the root of intermittent failure). Will change this back to the original
|
@npathai i have made the necessary changes and comments. |
Used AtomicLong instead of Integer in ConcurrentHashMap to make the increment calls atomic.
Ref: 643