Skip to content

Intermittent test failure in Throttling pattern #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iluwatar opened this issue Sep 23, 2017 · 9 comments
Closed

Intermittent test failure in Throttling pattern #643

iluwatar opened this issue Sep 23, 2017 · 9 comments
Assignees
@npathai
Labels
epic: build issue info: good first issue type: bug
Milestone
1.21.0

Comments

@iluwatar
Copy link
Owner

See https://travis-ci.org/iluwatar/java-design-patterns/builds/278878833
@iluwatar
Copy link
Owner Author

Ping @rastdeepanshu

@rastdeepanshu
Copy link
Contributor

@iluwatar i'll take a look.

@rastdeepanshu rastdeepanshu mentioned this issue Sep 25, 2017
Merged
@iluwatar iluwatar added this to the 1.18.0 milestone Oct 11, 2017
@iluwatar iluwatar mentioned this issue Oct 15, 2017
Merged
@iluwatar
Copy link
Owner Author

iluwatar commented Nov 5, 2017

https://s3.amazonaws.com/archive.travis-ci.org/jobs/297472315/log.txt?X-Amz-Expires=30&X-Amz-Date=20171105T181140Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJRYRXRSVGNKPKO5A/20171105/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=673ea97270fea2a3704c49a677d2d9c2ae9abcadce308545a49b2784928bd785

@iluwatar iluwatar reopened this Nov 5, 2017
@iluwatar
Copy link
Owner Author

https://travis-ci.org/iluwatar/java-design-patterns/builds/304766483?utm_source=email&utm_medium=notification

@iluwatar iluwatar removed this from the 1.18.0 milestone Jan 1, 2018
@iluwatar iluwatar mentioned this issue Jan 10, 2018
Merged
@iluwatar
Copy link
Owner Author

@rastdeepanshu it still sometimes fails, will you try to solve it?

@rastdeepanshu
Copy link
Contributor

@iluwatar I'll take a look.

@iluwatar
Copy link
Owner Author

iluwatar commented Mar 7, 2018

@rastdeepanshu any progress?

This was referenced Mar 11, 2018
Merged
Merged
iluwatar added a commit that referenced this issue Mar 31, 2018
@iluwatar
Disable flaky tests mentioned in issue #643 and #699
17ea0b1
@iluwatar
Copy link
Owner Author

Flaky test disabled in 17ea0b1. Still needs to be fixed.

christophercolumbusdog added a commit to christophercolumbusdog/java-design-patterns that referenced this issue May 26, 2018
@christophercolumbusdog
iluwatar#643 Fix flaky tests for throttling pattern
4ab46c7
iluwatar added a commit that referenced this issue May 27, 2018
@iluwatar
Merge pull request #752 from christophercolumbusdog/master
c713dbc 
#643 Fix flaky tests for throttling pattern
@iluwatar iluwatar added this to the 1.20.0 milestone May 27, 2018
@Argyro-Sioziou Argyro-Sioziou mentioned this issue Jun 1, 2018
Merged
@iluwatar
Copy link
Owner Author

iluwatar commented Jun 3, 2018

Unfortunately the fix did not work. See https://api.travis-ci.org/v3/job/384940670/log.txt. Reopening this issue.

@iluwatar iluwatar reopened this Jun 3, 2018
@iluwatar iluwatar removed this from the 1.20.0 milestone Jun 3, 2018
@npathai npathai self-assigned this Oct 15, 2018
npathai added a commit that referenced this issue Oct 15, 2018
@npathai
Resolves #643, test cases failed due to presence of global state in C…
ced1dfe 
…allsCount. Because AppTest was executed before B2BServiceTest, it scheduled 1 sec timer using ThrottleTimerImpl class. While resetting it used that global CallCount class reset() method, which reset all counters. So that causes thread safety issue because of unintended sharing of application state between test cases, which is not a good practice.
@npathai npathai mentioned this issue Oct 15, 2018
Merged
1 task
iluwatar pushed a commit that referenced this issue Oct 21, 2018
@npathai @iluwatar
Resolves #643, test cases failed due to global state in CallsCount (#803
922fd62 
)

* Resolves #643, test cases failed due to presence of global state in CallsCount. Because AppTest was executed before B2BServiceTest, it scheduled 1 sec timer using ThrottleTimerImpl class. While resetting it used that global CallCount class reset() method, which reset all counters. So that causes thread safety issue because of unintended sharing of application state between test cases, which is not a good practice.

* Updated class diagram png and added UCLS file
@iluwatar iluwatar added this to the 1.21.0 milestone Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npathai npathai

Labels
epic: build issue info: good first issue type: bug
Projects
None yet
Milestone
1.21.0
Development

No branches or pull requests
3 participants
@iluwatar @npathai @rastdeepanshu