-
-
Notifications
You must be signed in to change notification settings - Fork 27k
#176 Added new pattern - EIP Wire Tap #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- When
App.java
is run it doesn't send any data, just establishes the route, right? Can you make it send something also? - When
App.java
is run it doesn't terminate itself automatically, but has to be killed separately. Can you make it automatically stop? - Usually we have had a test that runs the
App.java
. Can you add this test to Wire Tap example also? See the other patterns for examples, specifically Message Channel pattern.
I wanted to create fully working EIP context. However, test for |
Yes, this is fine. Not sufficient testing alone, but it is a good addition to test that all our examples run correctly.
It is a big bonus if you can do that. I'm not that experienced with Camel and couldn't do that with Message Channel example. |
Ok. I'll refactor |
I have made changes according to your requirements. Unfortunately the build fails because of some test errors in |
@codinghog is your branch up-to-date with master? A fix was made to Throttling pattern a while ago, see #643 |
@iluwatar All tests passed, changes made as you have requested |
Good job @codinghog! Thanks for the contribution 👍 |
New pattern added - EIP Wire Tap.