Skip to content

#176 Added new pattern - EIP Wire Tap #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 16, 2017
Merged

Conversation

ghost
Copy link

@ghost ghost commented Oct 4, 2017

New pattern added - EIP Wire Tap.

  • Added new directory - eip-wire-tap
  • Added sources for wire tap pattern
  • Added tests
  • Added description to README.md file

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When App.java is run it doesn't send any data, just establishes the route, right? Can you make it send something also?
  • When App.java is run it doesn't terminate itself automatically, but has to be killed separately. Can you make it automatically stop?
  • Usually we have had a test that runs the App.java. Can you add this test to Wire Tap example also? See the other patterns for examples, specifically Message Channel pattern.

@ghost
Copy link
Author

ghost commented Oct 12, 2017

I wanted to create fully working EIP context. App.java sets up and starts Spring Boot application, which takes care of adding all the routes to the context. I can refactor it by dropping Spring Boot, setting up Apache Camel context by hand, running routes and terminating the app.

However, test for App.java will test only if there were any exceptions thrown during the execution. Do you want any tests for the route? I have checked the Message Channel pattern and there are no tests for actual route, only for App.java execution.

@iluwatar
Copy link
Owner

However, test for App.java will test only if there were any exceptions thrown during the execution

Yes, this is fine. Not sufficient testing alone, but it is a good addition to test that all our examples run correctly.

Do you want any tests for the route? I have checked the Message Channel pattern and there are no tests for actual route, only for App.java execution.

It is a big bonus if you can do that. I'm not that experienced with Camel and couldn't do that with Message Channel example.

@ghost
Copy link
Author

ghost commented Oct 12, 2017

Ok. I'll refactor App.java a little and add a test for it.

@ghost
Copy link
Author

ghost commented Oct 13, 2017

I have made changes according to your requirements. Unfortunately the build fails because of some test errors in throttling project. Any ideas?

@iluwatar
Copy link
Owner

@codinghog is your branch up-to-date with master? A fix was made to Throttling pattern a while ago, see #643

@ghost
Copy link
Author

ghost commented Oct 15, 2017

@iluwatar All tests passed, changes made as you have requested

@iluwatar iluwatar merged commit 41710cb into iluwatar:master Oct 16, 2017
@iluwatar
Copy link
Owner

Good job @codinghog! Thanks for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant