HIP PI backend issues warning during build

[steffenlarsen]

During build in CI, the HIP backend issues the following warning, which is in turn promoted to an error:

In file included from /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.hpp:34,
                 from /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:14:
/opt/rocm/hip/include/hip/hip_runtime.h:26:2: error: #warning "This file is deprecated. Use header files from HIP_PATH/include, where HIP_PATH corresponds to HIP install path" [-Werror=cpp]
   26 | #warning "This file is deprecated. Use header files from HIP_PATH/include, where HIP_PATH corresponds to HIP install path"
      |  ^~~~~~~
In file included from /opt/rocm-5.5.0/include/hip/hip_runtime.h:58,
                 from /opt/rocm/hip/include/hip/hip_runtime.h:31,
                 from /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.hpp:34,
                 from /__w/llvm/llvm/src/sycl/plugins/hip/pi_hip.cpp:14:

See for example post-commit of 0a6adea.

[steffenlarsen]

Temporary solution in #9458.

[steffenlarsen]

@npmiller - Ping for awareness.

[jinz2014]

Hi @npmiller ,

I took a look and wonder the change is:

set(PI_HIP_INCLUDE_DIR "${SYCL_BUILD_PI_HIP_ROCM_DIR}/hip/include") =>
set(PI_HIP_INCLUDE_DIR "${SYCL_BUILD_PI_HIP_ROCM_DIR}/include")

Reference
/opt/rocm/hip/include/hip/hip_runtime.h
/opt/rocm/include/hip/hip_runtime.h

[npmiller]

That's right @jinz2014 , I was a bit worried about older versions of HIP but even at 4.2 they were symlinking the HIP headers into include so just updating is fine, I opened a PR for it: #9550

[jinz2014]

Thanks.