Skip to content

Conversation

npmiller
Copy link
Contributor

Using the headers in hip/include/hip is deprecated since ROCm 5.2,
older versions of HIP also have this directory symlinked in include so
we can just update to the new path.

Fixes #9457

And reverts #9458

npmiller added 2 commits May 22, 2023 17:53
Using the headers in `hip/include/hip` is deprecated since ROCm 5.2,
older versions of HIP also have this directory symlinked in `include` so
we can just update to the new path.

Fixes intel#9457
@npmiller npmiller requested a review from a team as a code owner May 22, 2023 16:59
@npmiller npmiller requested a review from sergey-semenov May 22, 2023 16:59
@npmiller npmiller temporarily deployed to aws May 22, 2023 17:30 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to aws May 22, 2023 18:43 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to aws May 23, 2023 09:52 — with GitHub Actions Inactive
@npmiller npmiller temporarily deployed to aws May 23, 2023 10:24 — with GitHub Actions Inactive
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you for fixing the problem, @npmiller! 🚀

@steffenlarsen steffenlarsen merged commit af18927 into intel:sycl May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP PI backend issues warning during build
2 participants