Skip to content

[SYCL][Doc] Create sycl_ext_oneapi_queue_status_query.asciidoc #5860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 4, 2022
Merged

[SYCL][Doc] Create sycl_ext_oneapi_queue_status_query.asciidoc #5860

merged 15 commits into from
Apr 4, 2022

Conversation

TApplencourt
Copy link
Contributor

@TApplencourt TApplencourt commented Mar 22, 2022 •
edited by jbrodman
Loading

This PR add a new sycl extension named sycl_ext_oneapi_queue_status_query (sorry for the bad name... and the bad ascii doc file!).

It adds a few queue members functions (size, empty, get_wait_list) that were needed by some Argonne developers to port their code from CUDA to SYCL.

@TApplencourt TApplencourt requested a review from a team as a code owner March 22, 2022 16:27
@bader bader added enhancement New feature or request spec extension All issues/PRs related to extensions specifications Documentation Missing documentation for the code, compiler or runtime features, etc. labels Mar 22, 2022
@bader bader changed the title Create sycl_ext_intel_queue_status_querry.asciidoc [SYCL][Doc] Create sycl_ext_intel_queue_status_querry.asciidoc Mar 22, 2022
@TApplencourt
Copy link
Contributor Author

Applied the comments. Sorry and thanks!

@jbrodman jbrodman changed the title [SYCL][Doc] Create sycl_ext_intel_queue_status_querry.asciidoc [SYCL][Doc] Create sycl_ext_intel_queue_status_query.asciidoc Mar 22, 2022
@jbrodman jbrodman changed the title [SYCL][Doc] Create sycl_ext_intel_queue_status_query.asciidoc [SYCL][Doc] Create sycl_ext_oneapi_queue_status_query.asciidoc Mar 22, 2022
@jbrodman jbrodman self-requested a review March 22, 2022 17:53
gmlueck
gmlueck reviewed Mar 23, 2022
View reviewed changes
@TApplencourt
Copy link
Contributor Author

  • Rewrote overview section
  • Used ASCII Doc table for API call specification
  • Moved HIPSYCL credit to a new section

Thanks a lot for the review (and the time needed to do so)

gmlueck
gmlueck reviewed Mar 25, 2022
View reviewed changes
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated overview. This is looking good, just a few small comments.

@TApplencourt
Copy link
Contributor Author

Applied. Thanks!

PS: GitHub should really add a "thanks" emoji :)

gmlueck
gmlueck previously approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

jbrodman
jbrodman previously approved these changes Apr 4, 2022
View reviewed changes
bader
bader reviewed Apr 4, 2022
View reviewed changes
@TApplencourt TApplencourt dismissed stale reviews from jbrodman and gmlueck via 408d881 April 4, 2022 19:50
bader
bader approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bader bader merged commit b6143e5 into intel:sycl Apr 4, 2022
@TApplencourt TApplencourt deleted the patch-2 branch April 4, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader approved these changes

@jbrodman jbrodman jbrodman left review comments

@gmlueck gmlueck gmlueck left review comments

Assignees
No one assigned
Labels
Documentation Missing documentation for the code, compiler or runtime features, etc. enhancement New feature or request spec extension All issues/PRs related to extensions specifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TApplencourt @bader @jbrodman @gmlueck