Skip to content

Conversation

bso-intel
Copy link
Contributor

We should retain the build log when the program build failed. The build log is retrieved by SYCL RT.

We should retain the build log when the program build failed.
The build log is retrieved by SYCL RT.

Signed-off-by: Byoungro So <[email protected]>
@bso-intel bso-intel requested a review from a team as a code owner March 29, 2023 01:47
Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no build-log leak similar to what you were fixing for module leak?
Please also add a test that catches build-log being reported upon failed module build

@bso-intel bso-intel temporarily deployed to aws March 29, 2023 06:43 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 29, 2023 09:59 — with GitHub Actions Inactive
@bso-intel
Copy link
Contributor Author

Is there no build-log leak similar to what you were fixing for module leak?

Yes, this will result in a memory leak since a sycl::program is not created when L0 fails to build it.
So, RT never calls piProgramRelease().
Not sure how we can avoid this memory leak.

@smaslov-intel
Copy link
Contributor

Is there no build-log leak similar to what you were fixing for module leak?

Yes, this will result in a memory leak since a sycl::program is not created when L0 fails to build it. So, RT never calls piProgramRelease(). Not sure how we can avoid this memory leak.

Hmm. I see SYCL RT (expectedly) calling piProgramGetBuildInfo after the program build fails, so there must be a PI program to call it.

@bso-intel bso-intel temporarily deployed to aws March 29, 2023 19:36 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws March 30, 2023 03:24 — with GitHub Actions Inactive
@bso-intel
Copy link
Contributor Author

It seems these are known failures that are irrelevant to my patch in this PR.
Failed Tests (1):
SYCL :: AtomicRef/atomic_memory_order_acq_rel.cpp
Failed Tests (1):
SYCL :: GroupAlgorithm/reduce_sycl2020.cpp

@bso-intel bso-intel temporarily deployed to aws March 31, 2023 17:48 — with GitHub Actions Inactive
@bso-intel bso-intel closed this Apr 2, 2023
@bso-intel bso-intel reopened this Apr 2, 2023
@bso-intel bso-intel temporarily deployed to aws April 2, 2023 03:26 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws April 2, 2023 03:34 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws April 2, 2023 05:09 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws April 2, 2023 05:22 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws April 2, 2023 05:58 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws April 2, 2023 06:35 — with GitHub Actions Inactive
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
@bso-intel bso-intel temporarily deployed to aws April 3, 2023 21:55 — with GitHub Actions Inactive
@bso-intel bso-intel closed this Apr 4, 2023
@bso-intel bso-intel reopened this Apr 4, 2023
@bso-intel bso-intel temporarily deployed to aws April 4, 2023 00:33 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws April 4, 2023 01:29 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws April 4, 2023 02:01 — with GitHub Actions Inactive
Signed-off-by: Byoungro So <[email protected]>
@bso-intel bso-intel temporarily deployed to aws April 6, 2023 03:57 — with GitHub Actions Inactive
@bso-intel bso-intel temporarily deployed to aws April 6, 2023 04:53 — with GitHub Actions Inactive
@bso-intel
Copy link
Contributor Author

@intel/llvm-gatekeepers , please merge.

@stdale-intel stdale-intel merged commit 7d9f5ac into intel:sycl Apr 13, 2023
@bso-intel bso-intel deleted the retain-build-log branch April 13, 2023 18:15
jandres742 pushed a commit to jandres742/llvm that referenced this pull request Apr 21, 2023
jandres742 pushed a commit to jandres742/llvm that referenced this pull request Apr 24, 2023
jandres742 pushed a commit to jandres742/llvm that referenced this pull request May 3, 2023
jandres742 pushed a commit to jandres742/llvm that referenced this pull request May 16, 2023
jandres742 pushed a commit to jandres742/llvm that referenced this pull request May 23, 2023
jandres742 pushed a commit to jandres742/llvm that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants