-
Notifications
You must be signed in to change notification settings - Fork 807
[SYCL] Retain build-log when program build failed #8848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We should retain the build log when the program build failed. The build log is retrieved by SYCL RT. Signed-off-by: Byoungro So <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no build-log leak similar to what you were fixing for module leak?
Please also add a test that catches build-log being reported upon failed module build
Yes, this will result in a memory leak since a sycl::program is not created when L0 fails to build it. |
Hmm. I see SYCL RT (expectedly) calling |
Signed-off-by: Byoungro So <[email protected]>
It seems these are known failures that are irrelevant to my patch in this PR. |
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
Signed-off-by: Byoungro So <[email protected]>
@intel/llvm-gatekeepers , please merge. |
intel#8848 Signed-off-by: Jaime Arteaga <[email protected]>
intel#8848 Signed-off-by: Jaime Arteaga <[email protected]>
intel#8848 Signed-off-by: Jaime Arteaga <[email protected]>
intel#8848 Signed-off-by: Jaime Arteaga <[email protected]>
intel#8848 Signed-off-by: Jaime Arteaga <[email protected]>
intel#8848 Signed-off-by: Jaime Arteaga <[email protected]>
We should retain the build log when the program build failed. The build log is retrieved by SYCL RT.