Skip to content

[SYCL] Retain build-log when program build failed #8848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 13, 2023
Merged

[SYCL] Retain build-log when program build failed #8848

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8964573
[SYCL] Retain build-log when program build failed
bso-intel Mar 29, 2023
6635f36
clean up build log after RT retrives it
bso-intel Mar 29, 2023
cc9090e
Merge remote-tracking branch 'upstream/sycl' into retain-build-log
bso-intel Apr 2, 2023
d6c7801
move
bso-intel Apr 3, 2023
74d80fa
fix clang-format
bso-intel Apr 3, 2023
93c38b1
check the condition
bso-intel Apr 4, 2023
e522104
Merge remote-tracking branch 'upstream/sycl' into retain-build-log
bso-intel Apr 5, 2023
f5349c2
call piPrgramRelease after build failure
bso-intel Apr 5, 2023
eaa9c99
fix clang-format
bso-intel Apr 5, 2023
e6c8b1a
try to revert the latest change
bso-intel Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions sycl/plugins/level_zero/pi_level_zero.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3852,10 +3852,6 @@ pi_result piProgramBuild(pi_program Program, pi_uint32 NumDevices,
// RT calls piProgramRelease().
Program->State = _pi_program::Invalid;
Result = mapError(ZeResult);
if (Program->ZeBuildLog) {
ZE_CALL_NOCHECK(zeModuleBuildLogDestroy, (Program->ZeBuildLog));
Program->ZeBuildLog = nullptr;
}
if (ZeModule) {
ZE_CALL_NOCHECK(zeModuleDestroy, (ZeModule));
ZeModule = nullptr;
Expand Down Expand Up @@ -3923,6 +3919,18 @@ pi_result piProgramGetBuildInfo(pi_program Program, pi_device Device,
if (ParamValueSizeRet) {
*ParamValueSizeRet = LogSize;
}
if (ParamValue) {
// When the program build fails in piProgramBuild(), we delayed cleaning
// up the build log because RT later calls this routine to get the
// failed build log.
// To avoid memory leaks, we should clean up the failed build log here
// because RT does not create sycl::program when piProgramBuild() fails,
// thus it won't call piProgramRelease() to clean up the build log.
if (Program->State == _pi_program::Invalid) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the Program is a valid PI object (although in "invalid" state) and SYCL RT knows that since it calls this piProgramGetBuildInfo for it. That said, I think the correct fix would be for SYCL RT to call piProgramRelease after it is done with the program build-log retrieval.

ZE_CALL_NOCHECK(zeModuleBuildLogDestroy, (Program->ZeBuildLog));
Program->ZeBuildLog = nullptr;
}
}
return PI_SUCCESS;
}

Expand Down