Skip to content

Extension on Other filetypes #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CraigRegester opened this issue Dec 3, 2021 · 4 comments
Closed

Extension on Other filetypes #93

CraigRegester opened this issue Dec 3, 2021 · 4 comments
Assignees
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)

Comments

@CraigRegester
Copy link
Contributor

CraigRegester commented Dec 3, 2021

See issue #92 for examples

HL7 schemas with git-source-control is outputting with a .CLS extension. InterSystems ObjectScript extension (see output above), outputs with .hl7 like I would expect/prefer.

Same scenario also happens with LUT files. I have both LUT and HL7 in my Mappings in Settings but it makes no difference - though does folder them like I want/specify in the mapping. Can we respect the original extensions and just use a .gitattributes file to instruct 'make them pretty' in GitHub (may not be necessary as they are XML)

*.cls linguist-language=ObjectScript
*.mac linguist-language=ObjectScript
*.int linguist-language=ObjectScript
*.inc linguist-language=ObjectScript
*.inc linguist-language=ObjectScript
*.csp linguist-language=Html

*.sh text eol=lf
*.cls text eol=lf
*.mac text eol=lf
*.int text eol=lf
Dockerfil* text eol=lf
@isc-tleavitt isc-tleavitt added the bug Something isn't working label Dec 7, 2021
@isc-tleavitt
Copy link
Collaborator

@isc-svelury we should just always use the extension from the internal name.

@isc-tleavitt isc-tleavitt added the customer Based on customer feedback (as opposed to something identified by developers) label Dec 7, 2021
@isc-tleavitt
Copy link
Collaborator

Fixed in #100. Will need to get a new release out soon...

@CraigRegester
Copy link
Contributor Author

@isc-tleavitt echoing need for new release as last one was over 30 days now and I think you guys knocked out a ton of things (that would have been showstoppers for us) so excited to see if I can have others on our team start using this!

Appreciate you both, keep up the good work and thanks for all the efforts.

@isc-tleavitt
Copy link
Collaborator

@CraigRegester done - published 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working customer Based on customer feedback (as opposed to something identified by developers)
Projects
None yet
Development

No branches or pull requests

3 participants