-
Notifications
You must be signed in to change notification settings - Fork 8
Add Business Processess if they are not in source control #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There is no 'new document' hook when creating a new business process (it just registers as opening existing document), so we have to work around this. @isc-pbarton This is only a partial solution. This works only for compiled business processes, since there is no easy way to check (that I know of) if a class is a business process before it has been compiled. Though once a business process is compiled, it is reloaded, thus causing it to be added to source control. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
==========================================
- Coverage 40.54% 40.50% -0.04%
==========================================
Files 23 23
Lines 3137 3145 +8
==========================================
+ Hits 1272 1274 +2
- Misses 1865 1871 +6 ☔ View full report in Codecov by Sentry. |
This looks good to me. Can we make the same fix for Business Rules as well? And perhaps add a code comment that we are making up for an upstream issue. |
Does this issue occur for Business Rules? From my testing it seems like they get added automatically when created |
I'm seeing it with business rules if I start from the production configuration page. Add a new process of type EnsLib.MsgRouter.RoutingEngine, check "Auto-create rule", then open the auto-created rule. It has the "Add to Source Control" option on it. This is on IRIS 2023.1.3 |
@isc-pbarton That should work now too, though the Rule Editor does not call hooks when opened, so this will only work on Save/Compile |
Fixes #676