Skip to content

Fix adding favorites links on newer IRIS versions #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2025
Merged

Conversation

isc-pbarton
Copy link
Collaborator

Fixes #734
Fixed the query for adding favorite links. Newer IRIS versions have stricter validation when a table has a column of type %List.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.18%. Comparing base (c71bab2) to head (1e79a74).

Files with missing lines Patch % Lines
cls/SourceControl/Git/Utils.cls 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #737      +/-   ##
==========================================
+ Coverage   41.17%   41.18%   +0.01%     
==========================================
  Files          24       24              
  Lines        3184     3183       -1     
==========================================
  Hits         1311     1311              
+ Misses       1873     1872       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isc-pbarton isc-pbarton requested a review from isc-etamarch April 8, 2025 18:34
@isc-pbarton isc-pbarton merged commit 50c83a4 into main Apr 8, 2025
2 checks passed
@isc-pbarton isc-pbarton deleted the fix-favorites branch April 8, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing on latest Community Edition container
3 participants