Git links in favorites now actually work #757
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
=======================================
Coverage 41.20% 41.20%
=======================================
Files 24 24
Lines 3206 3206
=======================================
Hits 1321 1321
Misses 1885 1885 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
isc-tleavitt
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #734
The fix from #737 made the favorites links appear, but the hyperlink itself did not work because the SMP doesn't expect the URL to be in a $list format. See upstream reference DP-440691.
This fix is tested in both IRIS 2025.1.0 and 2023.1.3.