Skip to content

bug: React IonAlert/useIonAlert input label does not display #26915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 of 8 tasks
babycourageous opened this issue Mar 4, 2023 · 3 comments
Closed
4 of 8 tasks

bug: React IonAlert/useIonAlert input label does not display #26915

babycourageous opened this issue Mar 4, 2023 · 3 comments
Labels

Comments

@babycourageous
Copy link
Contributor

babycourageous commented Mar 4, 2023

Prerequisites

Ionic Framework Version

  • v4.x
  • v5.x
  • v6.x
  • v7.x
  • Nightly

Current Behavior

setting the label of an input using the config passet to the present fn from useIonAlert or an inline Alert does not result in a label for the input in the alert.

Expected Behavior

Alert input label should be visible and match the label set in config.

Steps to Reproduce

present an alert with useIonAlert() or inline and as part of the config set an input with a label.
open the alert and see the input - but no label.

Code Reproduction URL

https://github.com/babycourageous/ionic-alert-input-label-bug

Ionic Info

Ionic:

Ionic CLI : 6.20.1 (/Users/renedellefont/.fnm/node-versions/v16.13.1/installation/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/react 6.6.0

Capacitor:

Capacitor CLI : 4.7.0
@capacitor/android : not installed
@capacitor/core : 4.7.0
@capacitor/ios : not installed

Utility:

cordova-res : not installed globally
native-run : 1.7.2

System:

NodeJS : v16.13.1 (/Users/renedellefont/.fnm/node-versions/v16.13.1/installation/bin/node)
npm : 8.1.2
OS : macOS

Additional Information

the docs don't describe what each config item corresponds to (https://ionicframework.com/docs/api/alert#alertinput) so I am making the assumption label should correspond to the label for the input. If that's not the case, happy to close this as a non-issue!.

Thanks!

@ionitron-bot ionitron-bot bot added the triage label Mar 4, 2023
@babycourageous babycourageous changed the title bug: React useIonAlert input label does not display bug: React IonAlert/useIonAlert input label does not display Mar 4, 2023
@sean-perkins
Copy link
Contributor

Hello @babycourageous thanks for this issue!

The label property for alert inputs is only applied to checkboxes and radios.

We can do a better job of documenting this. I'll open a PR to correct this.

@babycourageous
Copy link
Contributor Author

Thanks for that update @sean-perkins ! I peeked at #26923 and 👍 to why it isn't implemented for text inputs.

@ionitron-bot
Copy link

ionitron-bot bot commented Apr 12, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants