docs(alert): alert input label is only for radio/checkbox #26923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
liamdebeasi
reviewed
Mar 7, 2023
|
I think that requires more investigation internally. The implementation doesn't render labels today, likely to align to iOS/MD design guidelines. We could render the label and add the label placement/etc. options to allow developers to build more "custom" alert form dialogs (and more accessible) post v7, but that needs to be vetted and designed out. Since the current behavior doesn't account for labels on text fields (input and textarea), I figured we should align the documentation around this for now. |
averyjohnston
approved these changes
Mar 8, 2023
8 tasks
liamdebeasi
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Label property on
AlertInputinterface is unclear to developers when it is used/displayed.Issue URL: #26915
What is the new behavior?
labelproperty to note it is only used for input typecheckboxorradioDoes this introduce a breaking change?
Other information
Related docs PR: ionic-team/ionic-docs#2810