Skip to content
This repository was archived by the owner on Aug 11, 2021. It is now read-only.

Fix IPLD paths on Windows #100

Closed
wants to merge 1 commit into from
Closed

Fix IPLD paths on Windows #100

wants to merge 1 commit into from

Conversation

Expyron
Copy link

@Expyron Expyron commented Oct 14, 2017

Fixes #99

@richardschneider
Copy link
Contributor

richardschneider commented Nov 5, 2017

Thanks @Expyron for your PR.

The real problem is much deeper in the stack, see ipfs/interface-datastore#12

When I get this all sorted out, I'll drop you a note.

@richardschneider
Copy link
Contributor

This is fixed in PR #104

@Expyron
Copy link
Author

Expyron commented Nov 14, 2017

@richardschneider

I still believe that this fix is better than what you used in PR #104 .

With the code in #104 , IPLD cannot resolve paths containing backslashes on Windows, making it have a different behavior than on Linux.

You can reproduce with (working on Linux, but not on Windows):
let cid = await ipfs.dag.put({'\\test\\':'test'}, {format: 'dag-cbor'}).catch((err) => { console.log(err)})
let obj = (await ipfs.dag.get(cid, "\\test\\").catch((err) => { console.log(err)})).value

@richardschneider
Copy link
Contributor

richardschneider commented Nov 14, 2017

I'm sorry, did not read your patch fully. There's been lot's of issues/PRs for Windows.

I will take a look at ipfs.dag.put.

cc @diasdavid

@richardschneider richardschneider self-assigned this Nov 14, 2017
@daviddias daviddias added the status/ready Ready to be worked label Jan 25, 2018
@daviddias
Copy link
Member

@richardschneider is this still a issue?

@daviddias daviddias added exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up labels Jan 26, 2018
@richardschneider
Copy link
Contributor

@diasdavid Just ran all the tests on windows and every test passed.

This PR is no longer required.

@richardschneider richardschneider added status/in-progress In progress and removed status/ready Ready to be worked labels Jan 29, 2018
@daviddias daviddias closed this Jan 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
exp/expert Having worked on the specific codebase is important P1 High: Likely tackled by core team if no one steps up status/in-progress In progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants