This repository was archived by the owner on Aug 11, 2021. It is now read-only.
fix: Windows interop #104
Merged
fix: Windows interop #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed running tests on a pre-commit as it prevents checking in incremental changes to a branch
daviddias
suggested changes
Nov 6, 2017
package.json
Outdated
| "test:browser": "aegir test --target browser", | ||
| "test": "aegir test --timeout 10000", | ||
| "test:node": "aegir test --target node --timeout 10000", | ||
| "test:browser": "aegir test --target browser --timeout 10000", |
There was a problem hiding this comment.
Please avoid using global timeouts. Try first here updating to latest Aegir and then seeing if you still need the timeouts.
|
@diasdavid build is failing with new latest aegir and no timeout specified. Shall I revert, or do u have another idea. |
daviddias
reviewed
Nov 6, 2017
package.json
Outdated
| "ipfs-block": "~0.6.0", | ||
| "ipfs-block-service": "~0.12.0", | ||
| "ipfs-repo": "~0.17.0", | ||
| "ipfs-repo": "^0.18.0", |
There was a problem hiding this comment.
We avoid using ^ for deps that are < 1.0.0. Keep ~
daviddias
reviewed
Nov 6, 2017
package.json
Outdated
| @@ -46,10 +46,10 @@ | |||
| "dependencies": { | |||
| "async": "^2.5.0", | |||
| "cids": "~0.5.2", | |||
| "interface-datastore": "^0.3.1", | |||
| "interface-datastore": "^0.4.1", | |||
There was a problem hiding this comment.
and it should use ~
|
@richardschneider you can increase the timeout of that specific batch of tests. I just meant to avoid global timeouts, it is important that we know which tests are really slow. |
daviddias
approved these changes
Nov 6, 2017
daviddias
suggested changes
Nov 6, 2017
src/index.js
Outdated
| @@ -215,9 +220,7 @@ class IPLDResolver { | |||
| if (!r) { | |||
| return callback(new Error('No resolver found for codec "' + options.format + '"')) | |||
| } | |||
| // TODO add support for different hash funcs in the utils of | |||
| // each format (just really needed for CBOR for now, really | |||
| // r.util.cid(node1, hashAlg, (err, cid) => { | |||
There was a problem hiding this comment.
Please bring back this TODO comment
|
@diasdavid ready for review |
This was referenced Nov 6, 2017
daviddias
approved these changes
Nov 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get running on windows.