Implement select IGP parameters on the primary loopback interface #2656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The loopback data is checked as a new 'loopback' type to allow IGP modules to register a subset of link/interface attributes as begin valid on the loopback interface * The loopback interface must be validated with the top-level 'validate_attributes' function, otherwise the module attributes are not recognized. * Loopback data is thus checked first as a dict/bool within the node data, and then rechecked against the new 'loopback' type (assuming the 'loopback' attribute is not set to True/False). * The 'module attribute can be False' list is extended to include the 'loopback' data type * We have to deal with 'is the IGP set to False on loopback' in numerous places within the generic routing code until we finally remove 'igp: False' data in 'remove_unused_igp' function * To make that work, the 'add_loopback_igp' call had to be moved, resulting in IGP information appearing on the loopback interface even when the IGP module is removed from the node. Fixes #2625 and solves #2624
|
@DanPartelly -- this should solve your "I only want one IGP on the loopback" challenge @jbemmel -- instead of leaving IGP attributes on the loopback (current behavior, now with "passive" flag) when the IGP module is removed from the node due to being useless (as in: no external interfaces are using it), I could remove them. Any thoughts? |
jbemmel
reviewed
Sep 4, 2025
I like cleaned up attributes, so yes I would prefer to remove them altogether |
jbemmel
approved these changes
Sep 4, 2025
DanPartelly
approved these changes
Sep 5, 2025
ipspace
added a commit
that referenced
this pull request
Sep 30, 2025
Using the infrastructure created in #2656, the VRF module validation of the loopback interface data allows module-specific loopback parameters. The extra loopback VRF parameters are copied into the interface data when the VRF module creates VRF loopback interfaces in the node data. Also: * Add 'bgp.advertise' as a valid loopback parameter as we have no VRF equivalent of 'bgp.advertise_loopback' node parameter. * Add VRF loopback OSPF area to a transformation test * Create a new error test that checks the VRF loopback validation code Implements #2659
ipspace
added a commit
that referenced
this pull request
Oct 5, 2025
Using the infrastructure created in #2656, the VRF module validation of the loopback interface data allows module-specific loopback parameters. The extra loopback VRF parameters are copied into the interface data when the VRF module creates VRF loopback interfaces in the node data. Also: * Add 'bgp.advertise' as a valid loopback parameter as we have no VRF equivalent of 'bgp.advertise_loopback' node parameter. * Add VRF loopback OSPF area to a transformation test * Create a new error test that checks the VRF loopback validation code Implements #2659
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2625 and solves #2624