Implement select IGP parameters on VRF loopbacks #2714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the infrastructure created in #2656, the VRF module validation of the loopback interface data allows module-specific loopback parameters. The extra loopback VRF parameters are copied into the interface data when the VRF module creates VRF loopback interfaces in the node data. Also: * Add 'bgp.advertise' as a valid loopback parameter as we have no VRF equivalent of 'bgp.advertise_loopback' node parameter. * Add VRF loopback OSPF area to a transformation test * Create a new error test that checks the VRF loopback validation code Implements #2659
Open
jbemmel
reviewed
Oct 4, 2025
jbemmel
reviewed
Oct 4, 2025
jbemmel
reviewed
Oct 4, 2025
jbemmel
reviewed
Oct 4, 2025
jbemmel
reviewed
Oct 4, 2025
Thank you! Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the infrastructure created in #2656, the VRF module validation of the loopback interface data allows module-specific loopback parameters.
The extra loopback VRF parameters are copied into the interface data when the VRF module creates VRF loopback interfaces in the node data.
Also:
Implements #2659