describe the HTTP method config #1769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
efiop
reviewed
Sep 9, 2020
efiop
reviewed
Sep 9, 2020
efiop
approved these changes
Sep 9, 2020
efiop
reviewed
Sep 10, 2020
Comment on lines
592
to
594
| - `method` - override the | ||
| [HTTP method](https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods) | ||
| to use for file uploads (e.g. `PUT`/`POST`). By default, `POST` is used. |
There was a problem hiding this comment.
I'm not sure I get how this works. Can you guys provide a quick example? What this describes so far is:
$ dvc remote modify myremote auth methodHow do you set the actual method? Why is the method a type of auth? Thanks
There was a problem hiding this comment.
pretty simple:
$ dvc remote modify myremote method PUT
There was a problem hiding this comment.
OK so this bullet shouldn't be nested under auth then 🙂 Or are both needed?
There was a problem hiding this comment.
Oops, didn't notice that. Good catch! Thanks!
efiop
reviewed
Sep 10, 2020
efiop
reviewed
Sep 10, 2020
shcheklein
approved these changes
Sep 10, 2020
|
This looks great! Anything I should add? |
This comment has been minimized.
This comment has been minimized.
|
@jorgeorpinel Done. |
jorgeorpinel
suggested changes
Sep 11, 2020
|
(I meant to approve there ☝️ 😋) Merged restyled PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concerns:
iterative/dvc#4553
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
This change is