-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Allow config option for HTTP method for uploads (Artifactory) #4553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Could you please contribute a doc fix for HTTP in https://dvc.org/doc/command-reference/remote/modify to include this new config option? And one more thing, I see that github is not able to tie your commit's author with your github profile. Likely you just need to add the email used in those commits to https://github.com/settings/emails |
@rfdickerson thank you for this Artifactory insight and the change 🚀 We had an internal discussion about a month ago regarding possible integration with tools like Artifactory and realized that we are lacking hands-on experience with these tools. I'd really appreciate it if you could share your experience. Please let me know if we can set up a quick chat - I can shoot an email to the address from your profile. |
@dmpetrov would love a quick chat and maybe a quick screen share demo of it working. My Expedia address should work fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rfdickerson ! 🙏
Use case
Our MLE team at Expedia Group uses JFrog's Artifactory for storing binary artifacts. While Artifactory supports an HTTP/HTTPS interface, instead of POST it only accepts PUT for the new artifacts. This PR provides an alternative in this case.
Documentation change:
iterative/dvc.org#1769
JFrog Artifactory HTTP REST API
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
This change is