-
Notifications
You must be signed in to change notification settings - Fork 397
ref: deprecate digest
option from HTTP remote
#2802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not remove it, but just clarify that it has been removed and put a link to a ticket in dvc repo, so people could give us feedback.
Agree to leave it for now with a note on which version it was removed but do we need to link to some GH ticket? I'd prefer to avoid that. Users can reach us via regular channels with feedback. Or is there a special reason we want to encourage feedback on this? Thanks |
@jorgeorpinel Just to have 1 place to point people to. |
digest
option from HTTP remote
Was it deprecated or removed though? |
The difference is vague. I've suggested to include a link above, but that might be excessive. The current approach will work fine for now. |
Agreed on the link. It's more of a question - keep
it seems that it was removed? So, why don't explicitly say |
I changed to "removed". I don't like the idea of linking to GH issues in general (seems fragile; we already have a few which are probably no longer relevant) but feel free to add the link to the appropriate ticket (I'm not sure which one @efiop referred to) and merge @isidentical. |
We have removed the digest option in iterative/dvc#6525