-
Notifications
You must be signed in to change notification settings - Fork 1.2k
http: migrate to fsspec & aiohttp #6525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9d58b47
to
c5b1926
Compare
@isidentical Btw, since we are depending on fsspec's core more and more (e.g. that lexist issue you've mentioned today), let's setup testing for upstream fsspec? E.g. as a daily build. |
Makes sense! |
@isidentical Also, could you please elaborate in the PR description on the things we are missing here and other differences introduced by this? E.g. digest auth. |
+1 for httpx. |
@skshetry could you elaborate, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one question.
@isidentical Please clarify the path we will take about digest auth. I know that we've talked about it privately, but we need it to be visible for everyone :) |
@efiop updated the PR description. |
For the record: digest auth from our perception seems to be used rare enough that it makes sense for us to take the risk and to drop it for now. If there will be demand to bring it back, we will consider investing time in it. This is bad to drop a feature like that, but in this case it is worth it to move our filesystems/objects forward. |
Hi. Do we know in what exact release (DVC version) this will be applied? For iterative/dvc.org#2802 (comment) |
@jorgeorpinel 2.7.1 |
Thanks |
Resolves #6413
Differences compared to the old HTTPFileSystem (requests based):
digest
authentication since it is not supported by the aiohttp, at least not yet. (there is an old PR, ~3 years old that is still open). Instead of a deprecation period, now the config optionauth
with the valuedigest
will raise an error saying that the option is not available. In the future, if this feature gets accepted to the aiohttp we could bring back the support, but it doesn't seem to be going to happen anytime soon.