Skip to content

test: s3: use moto to test multipart objects #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
efiop opened this issue Apr 15, 2019 · 4 comments · Fixed by #2282
Closed

test: s3: use moto to test multipart objects #1889

efiop opened this issue Apr 15, 2019 · 4 comments · Fixed by #2282
Assignees
@efiop
Labels
testing Related to the tests and the testing infrastructure

Comments

@efiop
Copy link
Contributor

efiop commented Apr 15, 2019

Currently, we are unable to use it because of this bug. When it is fixed, we should switch to it from using actual s3 for unit testing. Related to #1867
@efiop
Copy link
Contributor Author

efiop commented Apr 15, 2019

Related #907

@efiop
Copy link
Contributor Author

efiop commented Jul 15, 2019

For the record, submitted a fix getmoto/moto#2307 for that bug.

@efiop efiop self-assigned this Jul 15, 2019
@efiop efiop added the testing Related to the tests and the testing infrastructure label Jul 15, 2019
@efiop
Copy link
Contributor Author

efiop commented Jul 16, 2019

Patch is merged.

@efiop
Copy link
Contributor Author

efiop commented Jul 16, 2019

Need to use moto for multipart upload test

@efiop efiop mentioned this issue Jul 16, 2019
Merged
2 tasks
efiop added a commit to efiop/dvc that referenced this issue Jul 18, 2019
@efiop
tests: s3: use moto for multipart test
958a4fb 
Fixes iterative#1889

Signed-off-by: Ruslan Kuprieiev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efiop efiop

Labels
testing Related to the tests and the testing infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: s3: use moto for multipart test efiop/dvc
1 participant
@efiop