Skip to content

tests: s3: use moto for multipart test #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2019
Merged

tests: s3: use moto for multipart test #2282

merged 1 commit into from
Jul 18, 2019

Conversation

efiop
Copy link
Contributor

@efiop efiop commented Jul 16, 2019

Fixes #1889

Test time decreased from 10s to 0.5s.

Signed-off-by: Ruslan Kuprieiev [email protected]

  • Have you followed the guidelines in our
    Contributing document?

  • Does your PR affect documented changes or does it add new functionality
    that should be documented? If yes, have you created a PR for
    dvc.org documenting it or at
    least opened an issue for it? If so, please add a link to it.


@efiop efiop changed the title tests: s3: use moto for multipart test [WIP] tests: s3: use moto for multipart test Jul 16, 2019
@efiop efiop force-pushed the moto branch 6 times, most recently from 42f548f to 807dc81 Compare July 16, 2019 20:49
@@ -16,6 +16,7 @@ function retry {
# work or not.
retry pip install --upgrade pip setuptools wheel
retry pip install .[all,tests]
retry pip install git+https://github.com/spulec/moto
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe latest tag?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pared There is none unfortunately. Will use git sha until guys release new version.

@efiop efiop force-pushed the moto branch 2 times, most recently from 3c3059b to 57c1398 Compare July 18, 2019 17:41
@efiop efiop changed the title [WIP] tests: s3: use moto for multipart test tests: s3: use moto for multipart test Jul 18, 2019
@efiop efiop merged commit 993b1df into iterative:master Jul 18, 2019
@efiop efiop deleted the moto branch July 18, 2019 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: s3: use moto to test multipart objects
2 participants