You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Split Repo.collect() for pipelines usage and stage gathering:
Data related commands don't care about orderings of pipeline stages, whereas for pipelines,
things are more complex than collect() can handle.
This will also remove duplicated warnings currently on reproduce. Workaround on tag: getting rid of it #3699 for now
Why is there schema/serialization/deserialization in 3 places? Yeah, true.
Parallel logics of loading/transforming/dumping of Output, Dependency and Stages for single stage and pipeline stages (Requires further investigation)
StageLoader is too dynamic.
Messed with OutputDuplicationsError: Make sure it's safe to remove current stage from error message.
I find the long name of options --metrics and --plots misleading, since they only accept one metrics/plot file. What about just --metric and --plot? Cc @dmpetrov
@jorgeorpinel Those are just consistent with the rest of the options: --outs/--outs-no-cache/etc. We might want to introduce an alias or support commas like we do in --params. But for now could leave as is.
Most of the works is done. Next stage could be fixing the tests for the repro. (De)Serialization can be evaluated later, if we can do anything better. StageParams - the constants are something that we'll have to live with it.
Uh oh!
There was an error while loading. Please reload this page.
Tracking things to cleanup after #3676 is merged, in addition to suggestions in the PR:
tags
(will make life simpler) tag: getting rid of it #3699Repo.collect()
for pipelines usage and stage gathering:Data related commands don't care about orderings of pipeline stages, whereas for pipelines,
things are more complex than
collect()
can handle.This will also remove duplicated warnings currently on
reproduce
.Workaround on tag: getting rid of it #3699 for now
Output
,Dependency
andStages
for single stage and pipeline stages (Requires further investigation)StageLoader
is too dynamic.OutputDuplicationsError
: Make sure it's safe to remove current stage from error message.dump()
ordered (Only for Python==3.5).StageParams
andOutputParams
Of course, we need lots of tests and UI issues fixes, but this meta issue is only regarding code cleanups.
The text was updated successfully, but these errors were encountered: