tests serializing of stage to lockfile #3988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Jun 9, 2020
| `key_vals` - which is list of params with values, used in a lockfile | ||
| which is in the shape of: | ||
|
|
||
| def _serialize_params_values(params: List[ParamsDependency]): |
There was a problem hiding this comment.
Splitted serialization of params to serializing keys and values. Was getting too complex to understand.
skshetry
force-pushed
the
tests-serialize-lockfile
branch
from
17b0fb9 to
86d7c13
Compare
skshetry
commented
Jun 9, 2020
Comment on lines
+17
to
+18
| force_grid_wrap=0 | ||
| use_parentheses=True |
There was a problem hiding this comment.
There was a problem hiding this comment.
Why I added this is because, isort adds a \ on hanging indent for imports:
from dvc.stage.serialize import \
to_single_stage_lockfile as _to_single_stage_lockfileWhereas black formats it into this:
vs:
from dvc.stage.serialize import (
to_single_stage_lockfile as _to_single_stage_lockfile
)
skshetry
commented
Jun 9, 2020
| class TestPathConversion(TestCase): | ||
| def test(self): | ||
| stage = Stage(None, "path") | ||
| def test_path_conversion(dvc): |
There was a problem hiding this comment.
Converted to pytest format.
skshetry
changed the title
skshetry
commented
Jun 9, 2020
Comment on lines
+34
to
+39
| assert to_single_stage_lockfile(stage) == OrderedDict( | ||
| [ | ||
| ("cmd", "command"), | ||
| ("deps", [OrderedDict([("path", "input"), ("md5", "md-five")])]), | ||
| ] | ||
| ) |
There was a problem hiding this comment.
As the order is very important for the lockfile, most of the tests use ugly OrderedDict.
efiop
approved these changes
Jun 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.
❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Part of #3693