Skip to content

tests: unittests for dvcfile and some small fixes #4032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

skshetry
Copy link
Collaborator

Part of #3693. Added a few unittests, and some fixes along the way for functional tests.
Noticed one test was duplicated, hence removed.

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@skshetry skshetry added the testing Related to the tests and the testing infrastructure label Jun 12, 2020
@skshetry skshetry requested a review from efiop June 12, 2020 10:40
@skshetry skshetry self-assigned this Jun 12, 2020
assert len(stages) == 1
assert list(stages) == [stage1]


def test_load_singlestage(tmp_dir, dvc):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test was similar to what we have above test_run_load_one_on_single_stage.

@efiop efiop merged commit b94a18c into iterative:master Jun 12, 2020
@skshetry skshetry deleted the small-tests branch June 12, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to the tests and the testing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants