Skip to content

tests: flaky ssh tests #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
skshetry opened this issue May 27, 2020 · 3 comments · Fixed by #3898, #3899 or #3910
Closed

tests: flaky ssh tests #3888

skshetry opened this issue May 27, 2020 · 3 comments · Fixed by #3898, #3899 or #3910
Assignees
@skshetry
Labels
p1-important Important, aka current backlog of things to do testing Related to the tests and the testing infrastructure

Comments

@skshetry
Copy link
Collaborator

https://travis-ci.com/github/iterative/dvc/jobs/340412779

tests/unit/remote/ssh/test_connection.py::test_hardlink 
[gw1] [ 80%] FAILED tests/unit/remote/ssh/test_connection.py::test_hardlink 
tests/unit/remote/ssh/test_connection.py::test_copy 
[gw1] [ 80%] FAILED tests/unit/remote/ssh/test_connection.py::test_copy

I thought this was only failing on my machine, so I was ignoring it. But, looks like it occasionally happens on the CI. On my machine though this always appears.

Also, an important thing to note here is that, locally on my machine. it only fails when I'm running all of the tests, but when I rerun failed tests, it passes.
@skshetry skshetry added p1-important Important, aka current backlog of things to do testing Related to the tests and the testing infrastructure ci labels May 27, 2020
@efiop
Copy link
Contributor

efiop commented May 27, 2020

Might consider making ssh_server fixture's scope extend to session. That might help, but I'm not 100% sure.

@efiop efiop self-assigned this May 28, 2020
efiop added a commit to efiop/dvc that referenced this issue May 28, 2020
@efiop
tests: make ssh_server session scoped
2713376 
Fixes iterative#3888
@efiop efiop mentioned this issue May 28, 2020
Merged
3 tasks
efiop added a commit that referenced this issue May 28, 2020
@efiop
tests: make ssh_server session scoped (#3898)
02a52d0 
Fixes #3888
@efiop
Copy link
Contributor

efiop commented May 28, 2020

Nope, didn't solve https://travis-ci.com/github/iterative/dvc/jobs/340941135

@efiop efiop reopened this May 28, 2020
@efiop efiop removed their assignment May 28, 2020
@skshetry skshetry mentioned this issue May 28, 2020
Merged
@skshetry
Copy link
Collaborator Author

skshetry commented May 29, 2020 •
edited
Loading

Now, it''s failing, because of course, mock-ssh-server uses select.select(), why not?

I'll try creating a fix upstream later when I am done with #3881.

@skshetry skshetry reopened this May 29, 2020
@skshetry skshetry mentioned this issue May 29, 2020
Merged
3 tasks
@skshetry skshetry mentioned this issue Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skshetry skshetry

Labels
p1-important Important, aka current backlog of things to do testing Related to the tests and the testing infrastructure
Projects
None yet
Milestone
No milestone
2 participants
@efiop @skshetry