use selectors instead of select.select()
#3899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
changed the title
efiop
reviewed
May 28, 2020
|
@skshetry Unfortunately we won't see if this fixed it until we merge 🙂 Your sollution looks very good, let's fallback to select on windows and merge 🙂 |
skshetry
force-pushed
the
try-fixing-flakey-tests
branch
from
8da6357 to
c16851d
Compare
skshetry
changed the title
selectors instead of select.select()
efiop
reviewed
May 29, 2020
| @@ -237,11 +237,15 @@ def execute(self, cmd): | |||
| or channel.recv_ready() | |||
| or channel.recv_stderr_ready() | |||
| ): | |||
| import select | |||
| import selectors | |||
There was a problem hiding this comment.
Whoa, didn't know about this one! Neat!
pmrowla
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we were going >1024 on file descriptors. And, as select() does not work with >1024 file descriptors, using
pollmight fix the problem.Though, it does not support Windows. So, I have used a higher level API
selectorsthat will use whatever is most efficient for the current platform. Though, due to lack of*poll()in Windows, it will useselectthere.Closes #3888