params, plots, metrics: unify collection #4603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
changed the title
pared
changed the title
efiop
reviewed
Oct 6, 2020
dvc/repo/plots/__init__.py
Outdated
| return to_result(plots) | ||
|
|
||
| target_infos = {PathInfo(os.path.abspath(target)) for target in targets} | ||
| def is_plot(out): |
There was a problem hiding this comment.
Suggested change
| def is_plot(out): | |
| def _is_plot(out): |
same with others
efiop
reviewed
Oct 6, 2020
dvc/repo/collect.py
Outdated
| ) | ||
| wrong_targets.add(t) | ||
|
|
||
| target_infos = (target_infos ^ subtargets) - wrong_targets |
There was a problem hiding this comment.
Might be missing something, but why not just collect stuff that has passed the checks in the loop above?
efiop
reviewed
Oct 6, 2020
dvc/repo/collect.py
Outdated
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def collect( |
There was a problem hiding this comment.
Are you sure this couldn't be reorganized into meaningful parts? From the first glance looks cramped and hard to read.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to #4446