metrics/plots: test metrics collection on no target on revision #4789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
changed the title
pared
changed the title
pared
requested review from
pmrowla and
efiop
and removed request for
pmrowla
pared
changed the title
pmrowla
approved these changes
Oct 27, 2020
efiop
approved these changes
Oct 30, 2020
Yeah it's tricky. I'm considering suggesting "simple metrics" vs. "plot metrics" too. Just a note 🙂 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Related to #4446, #4603
In this change I introduce test checking behavior common both to
metricsandplots. In order to prevent test duplication amongmetricsandplotsI createdtest_commonundertests/func/metrics. I also movedtests/func/metrics->tests/func/metrics/metricstests/func/plots->tests/func/metrics/plotsSo that we would have logic package structure, where common tests would be above particular subcommand tests. Not sure if naming of "main" package is accurate. Considering that in our docs we name both
plotsandmetricsasmetricsI decided to go this way.