Use celery status as the exp show status #8369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karajan1001
added
ui
karajan1001
changed the title
|
@karajan1001 exp tests are failing in this PR as well |
karajan1001
force-pushed
the
fix8349
branch
4 times, most recently
from
6c2b751 to
d5ab506
Compare
|
@karajan1001 @pmrowla What's the status here? |
|
@karajan1001 this PR LGTM but it needs a rebase |
fix: iterative#8349 `tasks status turned to queued for 1 second before turned into success.` is because in previous the status is using the output of `get_running_exps` in `repo.expereiments` and when entering the collect result progress, the `get_running_exps` will mark the tasks to be not running because the `info.result` is not None. Here we use the output of the celery queue as the universal standard for the tasks status. 1. Use celery status as the exp show status
pmrowla
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #8349
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
is because in previous the status judgement is using the output of
get_running_expsinrepo.expereimentsdvc/dvc/repo/experiments/__init__.py
Line 462 in 8c48464
the
get_running_expswill mark the tasks to be not running because theinfo.resultis not None. when entering the collect result progress,dvc/dvc/repo/experiments/executor/base.py
Lines 491 to 493 in 8c48464
Here we use the output of the celery queue as the universal standard for the tasks status.