Code editors, Developer console #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javascript-translate-bot
added
the
review needed
|
|
danipoma
requested changes
Oct 24, 2020
There was a problem hiding this comment.
Just a minor thing as well to mention.
I believe that best practice should be to create new branch and add those changes there just in case so you can keep master branch in sync and promote changes in temporary branches.
Don't take my word for it though, this is my second day using git.
javascript-translate-bot
removed
the
review needed
|
Please make the requested changes. After it, add a comment "/done". |
javascript-translate-bot
added
the
changes requested
|
/done |
javascript-translate-bot
added
review needed
danipoma
approved these changes
Oct 25, 2020
javascript-translate-bot
added
needs +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.