Skip to content

Fix darwin target to work in github actions #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Fix darwin target to work in github actions #6

merged 1 commit into from
Mar 30, 2021

Conversation

geoah
Copy link
Contributor

@geoah geoah commented Mar 30, 2021

Firstly I wanted to say thank you for your work. OpenPGP mobile and it's flutter sister repo are one of the best and most complete examples on building golang and flutter integrations.

While trying to do something similar in a different golang project of mine, I bumped into what is possibly the same issue you were having that resulted in only bulding the x86_64 variant for macos.

This PR simply adds the SDKROOT as suggested in golang/go#44112 (comment)

Tried running this on my fork and seems ok.

@jerson
Copy link
Owner

jerson commented Mar 30, 2021

hi @geoah thanks you so much for this, im gonna merge it and check if works for me 👍🏽

@jerson jerson merged commit bb383bd into jerson:master Mar 30, 2021
@geoah geoah deleted the fix-darwin-github-actions branch March 30, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants