Skip to content

Conversation

Dekermanjian
Copy link
Collaborator

  1. updated level_trend component coord/param labels
  2. Adjusted the regression component to allow multivariate regression component specification
  3. Added a notebook for quick evaluation of the adjustments and additions made

2. Adjusted the regression component to allow multivariate regression component specification
3. Added a notebook for quick evaluation of the adjustments and additions made
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Owner

@jessegrabowski jessegrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving and we can merge in, just first please:

  1. use the pytensor block_diag
  2. check why the test_structral.py file is being marked as new

self.ssm["transition", :, :] = np.eye(self.k_states)
self.ssm["initial_state", :] = betas.reshape((1, -1)).squeeze()
T = np.eye(k_states)
self.ssm["transition", :, :] = linalg.block_diag(*[T for _ in range(k_endog)])
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use pt.linalg.block_diag instead, otherwise pytensor can't reason about the block diag

2. replaced scipy block diag with pytensor block diag
3. Added forecast to test model in multivariate ssm notebook
@jessegrabowski jessegrabowski merged commit 530f530 into jessegrabowski:multivariate-structural Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants