Notify users on CLA error

[scottgonzalez]

Right now we set the commit status and apply labels after auditing a PR, but neither of these will actually notify the contributor if there is a problem. We need to figure out how we want to notify contributors: via a PR comment or via an email.

[jzaefferer]

Travis sends emails, Angular/Google is using comments, their format looks like a good reference. They also add another comment when the CLA was signed.

[arschmitz]

A comment seems like a good way to go it sends an email to the contributor but its from Github not us which seems like a good thing.

[jzaefferer]

Having @jquerybot add a comment seems like a good idea, and should be pretty simple to implement.

[jzaefferer]

Something like this:

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA) at http://contribute.jquery.org/CLA/.

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

[arschmitz]

👍

[jzaefferer]

A more recent googlebot response:

Will see about integrating some of the changes into my draft.

[jzaefferer]

Updated comment template:

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.

---

If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

[jzaefferer]

To avoid spamming comments, I think we can keep track of event.payload.action, and only post a comment when the check failed and the action is event.payload.action === "opened".

Not sure yet where to actually implement this, since there are multiple locations where repo.setStatus is called. Hooking into that method would give us a single location, but seems like the wrong place.

[scottgonzalez]

Not sure yet where to actually implement this, since there are multiple locations where repo.setStatus is called. Hooking into that method would give us a single location, but seems like the wrong place.

There are multiple calls, but only one call that you care about: the one in finishAudit().