This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Audit: Notify user about missing signature with issue comment #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
This PR currently uses the nested-linting branch as its base, since the style changes would've caused too many conflicts. Will land them in the right order, so this shouldn't be a problem.
There are no tests for this, as the existing coverage doesn't touch the relevant modules and addressing that causes a lot of overhead. I've tested manually using the PR #45, running a modified
bin/audit-pr.jsthat always passesaction: "opened", and I've tested the server integration with a script that start the server with mocked signatures which change after a while, and a separate script that sends the correct payload for opening the PR, which also hasaction: "opened". I don't know how to integrate them into this repo, but if anyone else needs them, they're in this gist.