Temporarily work around Test262 tests broken by V8 bug #1416538 #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12wrigja
force-pushed
the
mark_broken_cldr42_tests
branch
from
f119fb9 to
fb15d0d
Compare
justingrant
changed the title
justingrant
changed the title
justingrant
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Needs to update a comment. CLDR 42 was the reason why V8 decided to poorly revert part of what CLDR 42 did, but the cause is V8 and it's a code bug.
Also you may want to change the file name to something a bit more generic, e.g. "failures after node 18" in case we get more issues like this.
12wrigja
force-pushed
the
mark_broken_cldr42_tests
branch
from
fb15d0d to
6dbf49f
Compare
|
I'm going to defer changing the file name because I'm starting to think there should be a better way to specify what version a specific expected-failure list applies to, instead of having to adjust logic in runtest262.mjs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 broke Test262 by releasing a regression that caused the output of
Intl.DateTimeFormat.p.formatto differ fromIntl.DateTimeFormat.p.format. See https://bugs.chromium.org/p/chromium/issues/detail?id=1416538.Until V8 fixes itself and those fixes get into CI, we'll skip the now-broken tests.