Skip to content

Temporarily work around Test262 tests broken by V8 bug #1416538 #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions runtest262.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ yargs(hideBin(process.argv))
const nodeVersion = parseInt(process.versions.node.split('.')[0]);
if (nodeVersion < 18) expectedFailureFiles.push('test/expected-failures-before-node18.txt');
if (nodeVersion < 16) expectedFailureFiles.push('test/expected-failures-before-node16.txt');
// Eventually this should be fixed and this condition should be updated.
if (nodeVersion >= 18) expectedFailureFiles.push('test/expected-failures-cldr42.txt');

// As we migrate commits from proposal-temporal, remove expected failures from here.
expectedFailureFiles.push('test/expected-failures-todo-migrated-code.txt');
Expand Down
13 changes: 13 additions & 0 deletions test/expected-failures-cldr42.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Failures in this file are expected to fail for all Test262 tests. To record
# expected test failures for the transpiled or optimized builds of the polyfill,
# see expected-failures-es5.txt and expected-failures-opt.txt respectively.

# # A regression in V8 (https://bugs.chromium.org/p/chromium/issues/detail?id=1416538)
# caused these tests to fail. We don't know when a fix is expected, but when it's fixed then
# these tests should start passing again.
staging/Intl402/Temporal/old/date-time-format.js
staging/Intl402/Temporal/old/datetime-toLocaleString.js
staging/Intl402/Temporal/old/instant-toLocaleString.js
staging/Intl402/Temporal/old/time-toLocaleString.js
staging/Intl402/Temporal/old/zoneddatetime-toLocaleString.js
intl402/DateTimeFormat/prototype/format/temporal-objects-resolved-time-zone.js
1 change: 0 additions & 1 deletion test/expected-failures.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@
# expected test failures for the transpiled or optimized builds of the polyfill,
# see expected-failures-es5.txt and expected-failures-opt.txt respectively.

# https://github.com/tc39/test262/pull/3548