Skip to content

Conversation

minrk
Copy link
Contributor

@minrk minrk commented Jul 28, 2015

  • add js-releated files to package_data, manifest
  • npm run build as part of build
  • skip npm when run from sdists
  • build_css should fail when its suprocesses fail
  • fetch less dependencies for building CSS (rather than extracting from the notebook, which doesn't install LESS sources)

minrk added 3 commits July 28, 2015 15:09
- add js-releated files to package_data, manifest
- `npm run build` as part of build
- skip npm when run from sdists
into less_include, so we can build our css

these files are not part of distributions or installs
@jdfreder
Copy link
Contributor

Looking at the notebook LESS fetching step, yikes! Makes me think ipywidgets should not depend on notebook less or that the notebook less should be available via bower and/or npm.

@minrk
Copy link
Contributor Author

minrk commented Jul 28, 2015

@jdfreder I absolutely agree that it shouldn't depend on the notebook LESS, and started going down that road, but there were a few things that got in the way. I can draft an example of that, if you want to see it.

The other option is the make the notebook include its less sources in an install, which is perhaps the simplest of all.

they weren't being installed
@minrk minrk mentioned this pull request Jul 29, 2015
@minrk
Copy link
Contributor Author

minrk commented Jul 29, 2015

#105 is the same, but instead of fetching the notebook LESS, it copies the flexbox mixins, and stops using the few variables it was using. I think it's probably the way to go, now that I see it.

@jdfreder
Copy link
Contributor

Ah yes, thanks. I just saw that. I agree, we can close this one in favor of that.

@jdfreder jdfreder closed this Jul 29, 2015
@minrk minrk deleted the setup-sdist branch July 29, 2015 00:12
@jdfreder jdfreder added this to the 4.0 milestone Jul 30, 2015
@jdfreder jdfreder modified the milestones: no action, 4.0 Jul 30, 2015
@github-actions github-actions bot added the resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Feb 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants