prepare for release #105
Merged
prepare for release #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add js-releated files to package_data, manifest - `npm run build` as part of build - skip npm when run from sdists
Closed
|
I prefer this :) |
into less_include, so we can build our css these files are not part of distributions or installs
they weren't being installed
ship some of flexbox, mixins
|
Looking good. Is there anything else you wanted to do here? |
|
No, I think this is a good start, at least. |
github-actions
bot
added
the
resolved-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run buildas part of buildand removing the few variables that were being used.
alternative to #104
main difference: instead of fetching notebook LESS, ship subset we actually use (a few flexbox mixins).
This may result in some divergence, since variables and bower configuration are not shared,
but it isolates the widget styling and is much simpler.
cc @jdfreder