Skip to content

Conversation

Aishwarya-Hebbar
Copy link
Contributor

@Aishwarya-Hebbar Aishwarya-Hebbar commented May 6, 2025

/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
Ran
go-get-kubernetes.sh -p 1.33.0

Does this PR introduce a user-facing change?:

Update kubernetes dependencies to v1.33.0`

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @Aishwarya-Hebbar. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from carlory and xing-yang May 6, 2025 08:48
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 6, 2025
@xing-yang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 6, 2025
@xing-yang
Copy link
Contributor

You need to run "go mod vendor"

@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the k8s-depenedencies-update branch from fa52858 to ecfa230 Compare May 7, 2025 06:14
@Aishwarya-Hebbar
Copy link
Contributor Author

/retest

)

replace k8s.io/api => k8s.io/api v0.32.0
replace k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.32.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 0.33.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aishwarya-Hebbar can you address this?

k8s.io/kube-scheduler v0.33.0 // indirect
k8s.io/kubectl v0.33.0 // indirect
k8s.io/kubelet v0.33.0 // indirect
k8s.io/mount-utils v0.33.0 // indirect
Copy link
Contributor

@sunnylovestiramisu sunnylovestiramisu May 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bug in v0.33.0 for mount-utils, should we wait for v0.33.1? kubernetes/kubernetes#131568

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The external provisioner should not use mount-utils at all, I think it's safe.

go.sum Outdated
Comment on lines 398 to 399
k8s.io/kubernetes v1.32.2 h1:mShetlA102UpjRVSGzB+5vjJwy8oPy8FMWrkTH5f37o=
k8s.io/kubernetes v1.32.2/go.mod h1:tiIKO63GcdPRBHW2WiUFm3C0eoLczl3f7qi56Dm1W8I=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be 1.33. I am not sure why the script did not update it. It could fix the failing tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update k8s.io/kubernetes v1.32.2 to v1.33.0 in go.mod file, go mod tidy && go mod vendor will update it here.

@jsafrane
Copy link
Contributor

Almost there...

pull-kubernetes-csi-external-provisioner-unit — Job failed.

pkg/controller/controller.go:642:18: non-constant format string in call to k8s.io/klog/v2.Warningf

klog.Warningf(deprecationWarning("fstype", prefixedFsTypeKey, ""))

Sometimes it happens that a new go compiler version introduces a new error / warning. In this case, a simple klog.Warning(deprecationWarning(...)) should fix the issue (i.e. Warningf -> Warning).

@Aishwarya-Hebbar Aishwarya-Hebbar force-pushed the k8s-depenedencies-update branch from a86e42e to 49b98cf Compare May 12, 2025 08:46
@Aishwarya-Hebbar
Copy link
Contributor Author

Almost there...

pull-kubernetes-csi-external-provisioner-unit — Job failed.

pkg/controller/controller.go:642:18: non-constant format string in call to k8s.io/klog/v2.Warningf

klog.Warningf(deprecationWarning("fstype", prefixedFsTypeKey, ""))

Sometimes it happens that a new go compiler version introduces a new error / warning. In this case, a simple klog.Warning(deprecationWarning(...)) should fix the issue (i.e. Warningf -> Warning).

Thanks @jsafrane for the quick improvement, hopefully now all jobs should succeed.

@jsafrane
Copy link
Contributor

jsafrane commented May 12, 2025

I filed #1375 for a flaky unit tests. We don't need to solve it here.

@jsafrane
Copy link
Contributor

/retest

@jsafrane
Copy link
Contributor

Filed yet another issue for the unit test flakes: #1376

@jsafrane
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Aishwarya-Hebbar, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit 69423c0 into kubernetes-csi:master May 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants