-
Notifications
You must be signed in to change notification settings - Fork 364
Upgrade kubernetes dependencies to 1.33.0 #1373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade kubernetes dependencies to 1.33.0 #1373
Conversation
Hi @Aishwarya-Hebbar. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
You need to run "go mod vendor" |
fa52858
to
ecfa230
Compare
/retest |
) | ||
|
||
replace k8s.io/api => k8s.io/api v0.32.0 | ||
replace k8s.io/legacy-cloud-providers => k8s.io/legacy-cloud-providers v0.32.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 0.33.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Aishwarya-Hebbar can you address this?
k8s.io/kube-scheduler v0.33.0 // indirect | ||
k8s.io/kubectl v0.33.0 // indirect | ||
k8s.io/kubelet v0.33.0 // indirect | ||
k8s.io/mount-utils v0.33.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bug in v0.33.0 for mount-utils, should we wait for v0.33.1? kubernetes/kubernetes#131568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The external provisioner should not use mount-utils at all, I think it's safe.
go.sum
Outdated
k8s.io/kubernetes v1.32.2 h1:mShetlA102UpjRVSGzB+5vjJwy8oPy8FMWrkTH5f37o= | ||
k8s.io/kubernetes v1.32.2/go.mod h1:tiIKO63GcdPRBHW2WiUFm3C0eoLczl3f7qi56Dm1W8I= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be 1.33. I am not sure why the script did not update it. It could fix the failing tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update k8s.io/kubernetes v1.32.2
to v1.33.0 in go.mod file, go mod tidy && go mod vendor
will update it here.
ecfa230
to
a86e42e
Compare
Almost there...
Sometimes it happens that a new go compiler version introduces a new error / warning. In this case, a simple |
a86e42e
to
49b98cf
Compare
Thanks @jsafrane for the quick improvement, hopefully now all jobs should succeed. |
I filed #1375 for a flaky unit tests. We don't need to solve it here. |
/retest |
Filed yet another issue for the unit test flakes: #1376 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Aishwarya-Hebbar, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Ran
go-get-kubernetes.sh -p 1.33.0
Does this PR introduce a user-facing change?: