Skip to content

Conversation

ddebroy
Copy link
Contributor

@ddebroy ddebroy commented May 8, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Cherry picks 6b31b6c to Release 1.1 branch and updates changelog.

Which issue(s) this PR fixes:
Fixes # kubernetes/kubernetes#77102

Special notes for your reviewer:
As requested in #275 (review)

Does this PR introduce a user-facing change?:

Handle deletion of CSI migrated volumes

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from davidz627 and jsafrane May 8, 2019 18:40
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 8, 2019
@ddebroy
Copy link
Contributor Author

ddebroy commented May 8, 2019

/cc @davidz627 @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 May 8, 2019 18:42
CHANGELOG-1.1.md Outdated
# Changelog since v1.1.0

## Notable Changes
* Handle deletion of volumes associated with in-tree plugins that are migrated to CSI ([#273](https://github.com/kubernetes-csi/external-provisioner/pull/273))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should point to 276

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - fixed.

@msau42
Copy link
Collaborator

msau42 commented May 8, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ddebroy, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit cfb8518 into kubernetes-csi:release-1.1 May 8, 2019
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants