Skip to content

Add comment about deletion #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add comment about deletion #275

wants to merge 1 commit into from

Conversation

ddebroy
Copy link
Contributor

@ddebroy ddebroy commented May 8, 2019 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design

/kind documentation

/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Update release notes to reflect changes to support deletion of CSI migrated volumes.

Which issue(s) this PR fixes:
Fixes # #273 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 8, 2019
@k8s-ci-robot k8s-ci-robot requested review from davidz627 and saad-ali May 8, 2019 08:15
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2019
@ddebroy
Copy link
Contributor Author

ddebroy commented May 8, 2019

/assign @msau42

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ddebroy
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: msau42

If they are not already assigned, you can assign the PR to them by writing /assign @msau42 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

j-griffith
j-griffith reviewed May 8, 2019
View reviewed changes
Copy link

@j-griffith j-griffith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2019
msau42
msau42 reviewed May 8, 2019
View reviewed changes
CHANGELOG-1.1.md
`--leader-election-type=leases` ([#261](https://github.com/kubernetes-csi/external-provisioner/pull/261))

## Other Notable Changes
* Handle deletion of volumes associated with in-tree plugins that are migrated to CSI ([#273](https://github.com/kubernetes-csi/external-provisioner/pull/273))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this in a new section

'''

Changes since 1.1.0

'''

Actually, can you cherry pick the fix to release-1.1 branch and then make the changelog PR in that branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry pick PR opened at #276

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should still merge this into master right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the next 1.2.0, we'll probably have a new release notes generation tool that can populate this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closing for now then.

@ddebroy ddebroy mentioned this pull request May 8, 2019
Merged
@ddebroy ddebroy closed this May 9, 2019
kbsonlong pushed a commit to kbsonlong/external-provisioner that referenced this pull request Dec 29, 2023
@k8s-ci-robot
Merge pull request kubernetes-csi#275 from kubernetes-csi/prow-update…
47dc1b0 
…-master

Update release tools
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-provisioner that referenced this pull request Jul 10, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 049659326..74e066a82
561816a 
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca5 Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec4 Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
@Aishwarya-Hebbar Aishwarya-Hebbar mentioned this pull request Jul 10, 2025
Open
Aishwarya-Hebbar added a commit to Aishwarya-Hebbar/external-provisioner that referenced this pull request Jul 14, 2025
@Aishwarya-Hebbar
Squashed 'release-tools/' changes from 049659326..74e066a82
9cb41ad 
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers
0a435bf98 Merge pull request kubernetes-csi#274 from andyzhangx/patch-5
cd7b4bba3 Bump golang to 1.24.2 to fix CVE-2025-22871
701dc34bc Merge pull request kubernetes-csi#273 from andyzhangx/patch-4
aeebd30e8 Bump golang to 1.24.0
f277d561f Merge pull request kubernetes-csi#270 from carlory/update-kind-version
90efb2ca5 Merge pull request kubernetes-csi#272 from andyzhangx/patch-3
9b616fec4 Bump golang to 1.23.6 to fix CVE-2024-45336, CVE-2025-22866
6dcb96a51 update default kind version to v0.25.0

git-subtree-dir: release-tools
git-subtree-split: 74e066a82d2ea14a68ff37f0e02ddc34619bbccd
dfajmon added a commit to dfajmon/csi-external-provisioner that referenced this pull request Sep 5, 2025
@dfajmon
Squashed 'release-tools/' changes from 0a435bf98..5f38a9075
87b3547 
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f62421 Update go to 1.24.6
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers

git-subtree-dir: release-tools
git-subtree-split: 5f38a907597230563f5e2213aea116acdd9d86bc
dfajmon added a commit to dfajmon/csi-external-provisioner that referenced this pull request Sep 5, 2025
@dfajmon
Squashed 'release-tools/' changes from 0a435bf98..5f38a9075
315c6cc 
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f62421 Update go to 1.24.6
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers

git-subtree-dir: release-tools
git-subtree-split: 5f38a907597230563f5e2213aea116acdd9d86bc
dfajmon added a commit to dfajmon/csi-external-provisioner that referenced this pull request Sep 5, 2025
@dfajmon
Squashed 'release-tools/' changes from 0a435bf98..5f38a9075
f3dbd6b 
5f38a9075 Merge pull request kubernetes-csi#282 from rhrmo/update-go-1.24.6
579f62421 Update go to 1.24.6
74e066a82 Merge pull request kubernetes-csi#279 from Aishwarya-Hebbar/update-csi-prow-version
6f236be7d Update CSI prow driver version to v1.17.0
0ee55894b Merge pull request kubernetes-csi#280 from xing-yang/update_go_1.24.4
9af101534 update to go 1.24.4
f5fec3e36 Merge pull request kubernetes-csi#275 from chrishenzie/emeritus
c5d285db8 Remove chrishenzie from kubernetes-csi-reviewers

git-subtree-dir: release-tools
git-subtree-split: 5f38a907597230563f5e2213aea116acdd9d86bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msau42 msau42 msau42 left review comments

@davidz627 davidz627 Awaiting requested review from davidz627

@saad-ali saad-ali Awaiting requested review from saad-ali

+1 more reviewer

@j-griffith j-griffith j-griffith left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@j-griffith j-griffith

@msau42 msau42

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ddebroy @k8s-ci-robot @j-griffith @davidz627 @msau42