Skip to content

🏃🏻‍♀️ Make gerred approver #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2020
Merged

🏃🏻‍♀️ Make gerred approver #774

merged 1 commit into from
Jan 31, 2020

Conversation

gerred
Copy link
Contributor

@gerred gerred commented Jan 22, 2020

Been active in reviews, very invested in this project and happy to help continue guiding CR to be an amazing tool!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 22, 2020
@gerred
Copy link
Contributor Author

gerred commented Jan 22, 2020

/assign @DirectXMan12

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2020
@gerred
Copy link
Contributor Author

gerred commented Jan 22, 2020

My commit grammar somehow was awful, but here we are. 🤷🏻‍♂️

@DirectXMan12
Copy link
Contributor

DirectXMan12 commented Jan 22, 2020 •
edited
Loading

s/admin/approver/ (slightly different IIRC, we can discuss that though), otherwise LGTM

@k8s-ci-robot
Copy link
Contributor

@gerred: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-controller-runtime-test 57eb510 link /test pull-controller-runtime-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@DirectXMan12
Copy link
Contributor

As stated above, I think this seems reasonable, but just in the spirit of fairness:

if anyone wants to burst into the room dramatically and shout: "stop, @gerred is actually an army time-travelling hyper-intelligent squirrels bent on global domination!", now is the time to do so :-)

@alexeldeib
Copy link
Contributor

"stop, @gerred is actually an army time-travelling hyper-intelligent squirrels bent on global domination!"

I read this as as a pro, not a con 😅

@gerred
Copy link
Contributor Author

gerred commented Jan 22, 2020 •
edited
Loading

I need this as an avatar now @DirectXMan12. :shipit: 🤖 🌐

@gerred
Copy link
Contributor Author

gerred commented Jan 22, 2020 •
edited
Loading

updated PR title to approver, I sheeped toward the line in the OWNER_ALIASES 🙃

@gerred gerred changed the title 🏃🏻‍♀️ Make gerred admin 🏃🏻‍♀️ Make gerred approver Jan 22, 2020
@kensipe
Copy link

kensipe commented Jan 22, 2020

+1 NB release the time traveling squirrels!

@alenkacz
Copy link
Contributor

woohoo, go @gerred 👍

vincepri
vincepri approved these changes Jan 23, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2020
@gerred gerred mentioned this pull request Jan 23, 2020
Closed
DirectXMan12
DirectXMan12 reviewed Jan 27, 2020
View reviewed changes
OWNERS_ALIASES
@@ -5,11 +5,11 @@ aliases:
- directxman12
- droot
- pwittrock
- gerred
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add an approvers section, otherwise, LGTM

@gerred
Copy link
Contributor Author

gerred commented Jan 27, 2020

@DirectXMan12 ah looks like maintainers is the right section here, fixing now

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2020
@gerred
Copy link
Contributor Author

gerred commented Jan 27, 2020

@DirectXMan12 done!

@vincepri
Copy link
Member

/lgtm

@mengqiy @DirectXMan12 Given that it has been 7 days for lazy approval, I think this should be good to go?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2020
@gerred
Copy link
Contributor Author

gerred commented Jan 30, 2020

@DirectXMan12 to resolve this, should I put myself under maintainer or approver?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2020
@DirectXMan12
Copy link
Contributor

I'll fix it.

@gerred @DirectXMan12
Make gerred approver
9fb0bbb 
Been active in reviews, very invested in this project and happy to help
continue guiding CR to be an amazing tool!
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 31, 2020
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, gerred

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 066ff64 into kubernetes-sigs:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 left review comments

@vincepri vincepri vincepri approved these changes

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@DirectXMan12 DirectXMan12

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gerred @DirectXMan12 @k8s-ci-robot @alexeldeib @kensipe @alenkacz @vincepri