-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add 'kensipe' as reviewer #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/assign @DirectXMan12 |
/assign @gerred |
👍 /lgtm |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kensipe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rebased based on label |
Thanks for your continued work on reviewing, and thanks for your stewardship of this ecosystem. As soon as #774 lands I will approve this PR. |
I'm not necessarily against this, but I'd prefer to see a couple (doesn't need to be a ton, just a couple) more substantial PRs/contributions before marking as official reviewer (if I've missed or forgotten a few, feel free to let me know) -- see https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/CONTRIBUTING-ROLES.md#becoming-a-reviewer |
sure thing @DirectXMan12 I was out on PTO but back to active status |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Signed-off-by: Ken Sipe <[email protected]>
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I've provided a number of reviews and code including the bump to kube 1.16
Signed-off-by: Ken Sipe [email protected]